<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x
...'
- code is contributed under BSD for core and main components (tm, sl, auth,
tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the
checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING
guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on
sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook
files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the
checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
Current implementation of pua_reginfo, when `publish_reginfo` is used, sets a
fixed `Expires` value of `3600` in the PUBLISH message, which may lead to many
entries in pua db for the same reginfo data if the client registers sin an
expiration < 1hr.
For example: a device registers every 2 minutes, in one hour pua db will have
30 entries for the same reg, because they're set to expire after 1hr.
In addition if this info is subscribed by another entity, the entity will
receive notifies with a lot of entries for the same reg.
Instead, like is done with the pua_dialoginfo, the Expires of the publish
should follow the expire of the registration.
This patch does exactly that, it sets the PUBLISH Expire to the reg expire
value.
There's only one caveat: that each usrloc record can have many contacts
with different expires, so the approach followed here is to set the PUBLISH
Expire value to the max reg expire value of all contacts of the same aor.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4355
-- Commit Summary --
* pua_reginfo: use expires from contact for publish rq
-- File Changes --
M src/modules/pua_reginfo/usrloc_cb.c (29)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4355.patch
https://github.com/kamailio/kamailio/pull/4355.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4355
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4...@github.com>
_______________________________________________
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the
sender!
