henningw left a comment (kamailio/kamailio#4328)

> > I haven't had the time for proper review, but at a quick look, a lot of 
> > files seem to be copied from auth module. If it is the case, then isn't it 
> > possible to reuse functions via intermodule API in the similar way that 
> > auth_db uses auth functions?
> 
> Our initial approach was to build a **complete drop-in replacement** for 
> `auth.so`.
> 
>     * Same API and function signatures as the original auth module
>     * Just swap `loadmodule "auth.so"` for `loadmodule "web3_auth.so"`
>     * Keep all the SIP digest auth stuff working, but use blockchain 
> verification instead of passwords
>     * Work with existing Kamailio configs without changes
> 
> 
> We understand your response and after seeing how `auth_db` uses the 
> intermodule API makes it clear that **building an extension module** would be 
> a smarter approach.
> 
> We're going to refactor our approach and upload an updated version.

Thank you, I would also prefer if this module uses using the auth inter-module 
API. I did a quick look to the code yesterday, but its difficult to review in 
its current shape with all this duplicated code.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4328#issuecomment-3084354210
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/4328/c3084354...@github.com>
_______________________________________________
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!

Reply via email to