miconda left a comment (kamailio/kamailio#4304)

I am not sure I understand exactly the use case. Is it about a REGISTER request 
getting to a SIP proxy that does parallel forking to many downstream SIP 
registrars? If yes, what do you want to happen with replies having the code >= 
300? To be forwarded back to the initial sender of the REGISTER request?

If it is about authentication, why not only 401/407? Shall a 400 be forwarded 
as well?

Also, the description does not seem right, for the INVITE, if the transaction 
uas status is `>= 200`, then only 2xx responses are forwarded (in the code it 
does not seem that >=300 are still forwarded for the INVITEs). Or I am missing 
something?

Looking at the overall diff at this moment:

  - 
https://patch-diff.githubusercontent.com/raw/kamailio/kamailio/pull/4304.diff

The first changed line to the LM_DBG() does not seem useful, just breaks the 
code formatting. Also, a non-necessary empty line is added.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4304#issuecomment-3033335855
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/4304/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the 
sender!

Reply via email to