Module: kamailio Branch: 6.0 Commit: 830a9f349f0356bc695b8744b4c96218e690d9e8 URL: https://github.com/kamailio/kamailio/commit/830a9f349f0356bc695b8744b4c96218e690d9e8
Author: Henning Westerholt <h...@gilawa.com> Committer: Xenofon Karamanos <22965395+xkara...@users.noreply.github.com> Date: 2025-06-26T10:53:14Z lrkproxy: improve randomness of cookie by using PNRG and random sequence numbers (cherry picked from commit 4935196ee8ce1d99e77c614aaa0131a1972580ed) --- Modified: src/modules/lrkproxy/lrkproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/830a9f349f0356bc695b8744b4c96218e690d9e8.diff Patch: https://github.com/kamailio/kamailio/commit/830a9f349f0356bc695b8744b4c96218e690d9e8.patch --- diff --git a/src/modules/lrkproxy/lrkproxy.c b/src/modules/lrkproxy/lrkproxy.c index bc0a83f4e23..ef6a347105b 100644 --- a/src/modules/lrkproxy/lrkproxy.c +++ b/src/modules/lrkproxy/lrkproxy.c @@ -77,6 +77,7 @@ #include "../../core/dset.h" #include "../../core/route.h" #include "../../core/kemi.h" +#include "../../core/rand/fastrand.h" #include "../../modules/tm/tm_load.h" #include "lrkproxy.h" #include "lrkproxy_hash.h" @@ -158,7 +159,6 @@ static void mod_destroy(void); static int lrkproxy_disable_tout = 60; static int lrkproxy_retr = 5; static int lrkproxy_tout = 1; -static pid_t mypid; static unsigned int myseqn = 0; //static str nolrkproxy_str = str_init("a=nolrkproxy:yes"); //static str extra_id_pv_param = {NULL, 0}; @@ -668,9 +668,10 @@ static int child_init(int rank) return 0; } - /* Iterate known LRK proxies - create sockets */ - mypid = getpid(); + /* random start value for for cookie sequence number */ + myseqn = fastrand(); + /* Iterate known RTP proxies - create sockets */ lrkp_socks = (int *)pkg_malloc(sizeof(int) * lrkp_no); if(lrkp_socks == NULL) { LM_ERR("no more pkg memory\n"); @@ -791,7 +792,7 @@ static char *gencookie(void) { static char cook[34]; - sprintf(cook, "%d_%u ", (int)mypid, myseqn); + sprintf(cook, "%d_%u ", fastrand(), myseqn); myseqn++; return cook; } _______________________________________________ Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org To unsubscribe send an email to sr-dev-le...@lists.kamailio.org Important: keep the mailing list in the recipients, do not reply only to the sender!
