@lbalaceanu commented on this pull request.


> @@ -427,6 +427,14 @@ int rule_translate(sip_msg_t *msg, str *instr, 
> dpl_node_t *rule,
                return 0;
        }
 
+       if(pcre_md == NULL) {
+               pcre_md = pcre2_match_data_create(MAX_REPLACE_WITH, NULL);

Hi @linuxmaniac - thank you, I was not aware about that compile context usage 
you mentioned. However, I also think that because we are using a static 
variable we can get away with allocating via malloc/free once. Please tell me 
if you want it changed however.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4289#discussion_r2158753561
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/4289/review/2945752...@github.com>
_______________________________________________
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!

Reply via email to