@tsearle commented on this pull request.


> +                             else if(str_eq(&key, "from-tags")) {
+                                       err = "missing value";
+                                       if(!val.s)
+                                               goto error;
+
+                                       if(!ng_flags->from_tags) {
+                                               ng_flags->from_tags =
+                                                               
bencode_list(ng_flags->dict->buffer);
+                                       }
+                                       
bencode_list_add_str(ng_flags->from_tags, &val);
+                               } else

I looked some more about merging the logic.... from-tag is a string in flags, 
so it doesn't support specifying it multiple times...

also there is som logic for checking that from-tag is set when no sip_msg is 
present,  so I feel more comfortable keeping it as is

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4274#discussion_r2137053765
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/4274/review/2912189...@github.com>
_______________________________________________
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!

Reply via email to