- format as well
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x
...'
- code is contributed under BSD for core and main components (tm, sl, auth,
tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the
checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING
guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on
sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook
files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the
checkboxes that apply -->
- [] PR should be backported to stable branches
- [ ] Tested changes locally
- [x] Related to issue #4227
#### Description
<!-- Describe your changes in detail -->
There was missing information of type identifiers that can be used in [rpc
tutorial
docs](https://www.kamailio.org/docs/docbooks/5.7.x/rpc_api/rpc_api.html#rpc.data_types).
This is an update to those docs. The most recent I could find was for 5.7.
Maybe there is a need for manual updating the page?
Also during the relevant PR #4227 , we found the `t` identifier is never used
in the code. since it can overflow on 64bit systems due to being a `long` and
not `int` type when saved/load, maybe we can remove it completely?. One can
just cast the `time_t` to the relevant type and use the correct identifier as
done in
https://github.com/kamailio/kamailio/blob/2081b3aac394223b68b849fbac2a9e5ac4392334/src/modules/dispatcher/dispatcher.c#L1978-L1990
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4228
-- Commit Summary --
* Update type identifiers that can be used in the RPC API
-- File Changes --
M doc/tutorials/rpc/kamailio_rpc.xml (86)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4228.patch
https://github.com/kamailio/kamailio/pull/4228.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4228
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4...@github.com>
_______________________________________________
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the
sender!
