Module: kamailio
Branch: master
Commit: b17038ec072b1854fa2fae1c2d4725c1471ef8ac
URL: 
https://github.com/kamailio/kamailio/commit/b17038ec072b1854fa2fae1c2d4725c1471ef8ac

Author: Daniel-Constantin Mierla <mico...@gmail.com>
Committer: Daniel-Constantin Mierla <mico...@gmail.com>
Date: 2025-02-13T09:18:00+01:00

xprint: init globals when declared

---

Modified: src/modules/xprint/xp_lib.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/b17038ec072b1854fa2fae1c2d4725c1471ef8ac.diff
Patch: 
https://github.com/kamailio/kamailio/commit/b17038ec072b1854fa2fae1c2d4725c1471ef8ac.patch

---

diff --git a/src/modules/xprint/xp_lib.c b/src/modules/xprint/xp_lib.c
index fda12a82fc3..567e62ade86 100644
--- a/src/modules/xprint/xp_lib.c
+++ b/src/modules/xprint/xp_lib.c
@@ -56,7 +56,10 @@
 static str str_null = STR_STATIC_INIT("<null>");
 static str str_empty = STR_STATIC_INIT("");
 static str str_per = STR_STATIC_INIT("%");
-static str str_hostname, str_domainname, str_fullname, str_ipaddr;
+static str str_hostname = STR_NULL;
+static str str_domainname = STR_NULL;
+static str str_fullname = STR_NULL;
+static str str_ipaddr = STR_NULL;
 
 enum xl_host_t
 {
@@ -1835,14 +1838,7 @@ int xl_mod_init()
                PKG_MEM_ERROR;
                return -1;
        }
-       if(gethostname(s, HOSTNAME_MAX) < 0) {
-               str_fullname.len = 0;
-               str_fullname.s = NULL;
-               str_hostname.len = 0;
-               str_hostname.s = NULL;
-               str_domainname.len = 0;
-               str_domainname.s = NULL;
-       } else {
+       if(gethostname(s, HOSTNAME_MAX) >= 0) {
                str_fullname.len = strlen(s);
                s = pkg_reallocxf(
                                s, str_fullname.len + 1); /* this will leave 
the ending \0 */
@@ -1870,8 +1866,6 @@ int xl_mod_init()
                }
        }
 
-       str_ipaddr.len = 0;
-       str_ipaddr.s = NULL;
        if(str_fullname.len) {
                he = resolvehost(str_fullname.s);
                if(he) {

_______________________________________________
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!

Reply via email to