#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, 
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [-] Related to issue #XXXX (replace XXXX with an open issue number)

#### Description
- icid-value is only 17 characters and not unique 
- Re-parsing of generated PCV with icid-generated is 2 characters too short, 
cutting generated-by value or creating false warning

Following warning was produced, which shows the problem.
> WARNING: siputils [chargingvector.c:240]: sip_parse_charging_vector(): 
icid-generated-at is missing icid-> value=4557000A000E52000;icid-generated-a

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/4026

-- Commit Summary --

  * siputils: generated icid-value too short

-- File Changes --

    M src/modules/siputils/chargingvector.c (6)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/4026.patch
https://github.com/kamailio/kamailio/pull/4026.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4026
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/4...@github.com>
_______________________________________________
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!

Reply via email to