@xkaraman commented on this pull request.


> @@ -3715,6 +3721,29 @@ int pv_set_xto_attr(struct sip_msg *msg, pv_param_t 
> *param, int op,
                        }
                        buf.len = val->rs.len;
                        memcpy(buf.s, val->rs.s, val->rs.len);
+
+                       /* Check if the URI is enclosed in angle brackets */
+                       is_enclosed = is_uri_enclosed(msg, tb);
+                       /* If uri is not enclosed, we need to enclose it in < >
+                               before adding display name */
+                       if(!is_enclosed) {

Indeed, it's a simple condition for now, but what if we want a more concrete 
way to identify the enclosure (assuming it fails in some strange case)? We can 
modify the function and be done; that's why I introduced the function. 

Nevertheless, I can of course remove it completely.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3935#discussion_r1781083927
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3935/review/2337470...@github.com>
_______________________________________________
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

Reply via email to