I think in general it shouldn;t be merged.
But I am also not really familiar and might have understood the inner workings
of the modules.
Some points though, might need updating like:
- [re split between itself and its child--both of them gone have
x/2.](https://www.kamailio.org/docs/modules/stable/modules/pike.html#idm153) I
can't match this somewhere in the code, and maybe the limits are not what the
dev guide suggests.
- when doing some debuging/testing and calling `kamcmd pike.list ALL` seems to
have list nodes with negative expire (probably shouldn't exist and taken into
account) and doesn't refresh the nodes correctly if requests are coming from
this subnet.
```
Apr 15 10:11:37 app01 kam5.7.2/sbin/kamailio[358099]: DEBUG: pike
[pike_rpc.c:78]: traverse_subtree(): pike:rpc traverse_subtree, not IP leaf,
depth: 0, ip: x.0.0.0 hits[0,0], expires: -291
Apr 15 10:11:37 app01 kam5.7.2/sbin/kamailio[358099]: DEBUG: pike
[pike_rpc.c:49]: traverse_subtree(): pike:rpc traverse_subtree, depth: 1, byte:
203
Apr 15 10:11:37 app01 kam5.7.2/sbin/kamailio[358099]: DEBUG: pike
[pike_rpc.c:78]: traverse_subtree(): pike:rpc traverse_subtree, not IP leaf,
depth: 1, ip: x.y.0.0 hits[0,0], expires: -291
Apr 15 10:11:37 app01 kam5.7.2/sbin/kamailio[358099]: DEBUG: pike
[pike_rpc.c:49]: traverse_subtree(): pike:rpc traverse_subtree, depth: 2, byte:
64
Apr 15 10:11:37 app01 kam5.7.2/sbin/kamailio[358099]: DEBUG: pike
[pike_rpc.c:78]: traverse_subtree(): pike:rpc traverse_subtree, not IP leaf,
depth: 2, ip: z.y.z.0 hits[0,0], expires: -171
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3806#issuecomment-2056466304
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3806/c2056466...@github.com>
_______________________________________________
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
