<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x
...'
- code is contributed under BSD for core and main components (tm, sl, auth,
tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the
checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING
guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on
sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils,
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook
files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the
checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This PR fixes small bugs, and improves docs.
#### Main bug fix:
- Fixup now should be able to handle the string from `.cfg` with multiple PVs,
strings, and more.
- Add fixup_free functions
#### Smaller fixes:
- `base_folder` should not contain a trailing slash. Trailing slash is allowed,
but resulting paths can contain `//log_file.extenion`, which in more OS is fine
and equal to `/`.
- Add initial Readme and fix some docs.
- Switch to `str` type in internal types for better string handling.
- Free message when done
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3756
-- Commit Summary --
* file_out: Change default base folder format
* file_out: Add initial Readme and improve docs
* file_out: Switch to str type for string handling
* file_out: Free message when done
* file_out: Improve logging
* file_out: Fix fixup functions to handle all string.
-- File Changes --
A src/modules/file_out/README (171)
M src/modules/file_out/doc/file_out_admin.xml (4)
M src/modules/file_out/file_out.c (52)
M src/modules/file_out/types.c (19)
M src/modules/file_out/types.h (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3756.patch
https://github.com/kamailio/kamailio/pull/3756.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3756
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3...@github.com>
_______________________________________________
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
