Xenofon did a review of the modules that uses diversion (diversion, 
sipcapture). The diversion module was tested with the PR. The sipcapture does 
only seems to store the header content in a string database field, so it should 
be fine. Regarding the SIP msg cloning, I reviewed the sip_msg_clone.c file. 
The diversion uses the same approach as the PPI and PAI headers, so it seems to 
be ok. There is no usage of the relevant diversion header types in tm. The main 
parser free function was adapted.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3651#issuecomment-1842533782
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3651/c1842533...@github.com>
_______________________________________________
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

Reply via email to