Hello, if no further comments, then I would suggest that Victor does the clang-format for branches 5.7 and 5.6 whenever he gets time -- he did it for master branch and reusing the same procedure hopefully results in good consistency across branches that will facilitate easier backporting.
Cheers, Daniel On 08.11.23 17:43, Daniel-Constantin Mierla wrote: > Hello, > > yes, large change in "presentation" of code, but no new features. The > 5.6 should be considered, too. > > Cheers, > Daniel > > On 08.11.23 10:26, Henning Westerholt wrote: >> Hello, >> >> it will be a rather large change, but nothing in general against it. >> >> Maybe you can also discuss at that occasion about the stable branch 5.6, I >> think the last minor release was there in March 2023. >> The standard workflow of cherry-picking changes from the newer branch would >> then also not work anymore for the 5.6 branch, after the 5.7 formatting >> change was done. >> >> Thanks, >> >> Henning >> >> >> -- >> Henning Westerholt - https://skalatan.de/blog/ >> Kamailio services - https://gilawa.com >> >> >> >>> -----Original Message----- >>> From: Daniel-Constantin Mierla via sr-dev <sr-dev@lists.kamailio.org> >>> Sent: Mittwoch, 8. November 2023 10:03 >>> To: Kamailio (SER) - Devel Mailing List <sr-dev@lists.kamailio.org> >>> Cc: Daniel-Constantin Mierla <mico...@gmail.com> >>> Subject: [sr-dev] clang-formatting branch 5.7 >>> >>> Hello, >>> >>> while couple of developers are at Kamailio project meeting in Dusseldorf, it >>> was somehow agreed here that it would be easier to backport fixes from >>> master to branch 5.7 if the code in that stable branch is going to be >>> formatted >>> using clang like it was done for master. >>> >>> Should anyone has any remarks against it, let's discuss. If not, probably >>> it is >>> going to be done in couple of days, then plan to release 5.7.3. >>> >>> Cheers, >>> Daniel >>> >>> -- >>> Daniel-Constantin Mierla (@ asipto.com) >>> twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy and >>> Development Services >>> >>> _______________________________________________ >>> Kamailio (SER) - Development Mailing List To unsubscribe send an email to >>> sr- >>> dev-le...@lists.kamailio.org > -- > Daniel-Constantin Mierla (@ asipto.com) > twitter.com/miconda -- linkedin.com/in/miconda > Kamailio Consultancy and Development Services > Kamailio Advanced Training - Online - Nov 14-16, 2023 -- asipto.com > -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy and Development Services Kamailio Advanced Training - Online - Nov 14-16, 2023 -- asipto.com _______________________________________________ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
