@henningw commented on this pull request.
> + /* we don't register null functions */
+ if (f==0) {
+ LM_CRIT("null callback function\n");
+ return E_BUG;
+ }
+
+ /* build a new callback structure */
+ if ( types & PCSCF_CONTACT_UPDATE){
+ if (!(cbp_registrar=(struct ul_callback*)shm_malloc(sizeof( struct
ul_callback)))) {
+ LM_ERR("no more share mem\n");
+ return E_OUT_OF_MEM;
+ }
+ cbp_registrar->callback = f;
+ }
+ else{
+ if (!(cbp_qos=(struct ul_callback*)shm_malloc(sizeof( struct
ul_callback)))) {
This variable is causing a conflict with ims_qos module:
/usr/bin/ld:
ims_qos_mod.o:./src/modules/ims_qos/./../ims_usrloc_pcscf/../ims_usrloc_pcscf/usrloc.h:246:
multiple definition of `cbp_qos';
cdpeventprocessor.o:./src/modules/ims_qos/./../ims_usrloc_pcscf/../ims_usrloc_pcscf/usrloc.h:246:
first defined here
Should be renamed
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3279#pullrequestreview-1174761045
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3279/review/[email protected]>_______________________________________________
Kamailio (SER) - Development Mailing List
[email protected]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
