@tao-communications great job, thank you. i do have a final request, when 
that's done, please squash your commits into a single commit, `kazoo: add basic 
kemi support`

i feel that `kazoo_route_no` doesn't express well the intent for the variable 
which is to use `kemi` instead of `cfg`.

can you please rename `kazoo_route_no`  to `kazoo_kemi_enabled` with default 0 
and set it to 1 in  
[here](https://github.com/kamailio/kamailio/pull/2324/files#diff-52d37ad2407d869cdcee8ffc29166e62R330)
and then use 
```
if ( kazoo_kemi_enabled )  {
   do kemi routine
} else {
   do cfg routine
}
```
where applicable, for example in `fire_init_event`
```
        if (kazoo_kemi_enabled) {
                return fire_init_event_kemi();
        }
        else {
                return fire_init_event_cfg();
        }
`` 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2324#issuecomment-631961748
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Reply via email to