#### Pre-Submission Checklist
- [ x] Commit message has the format required by CONTRIBUTING guide
- [ x] Commits are split per component (core, individual modules, libs, utils, 
...)
- [ x] Each component has a single commit (if not, squash them into one commit)
- [ x] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [ x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
- [ x] PR should be backported to stable branches (5.3 would be nice; earlier 
doesn't help me)
- [x] Tested changes locally (with these, the build gets vastly further)

#### Description
This PR has two changes for building on NetBSD.

One is simply adding -lm to the link line for kamailio, as math functions are 
used.

The other is changing the use of -ldl to a variable, leaving that at -ldl most 
places, and setting it to empty on NetBSD.  (NetBSD does not have a 
/usr/lib/libdl.* and dlopen does not require any link line arguments.)

I am pretty sure that my changes won't affect the build on non-NetBSD.

Thanks,
Greg
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2256

-- Commit Summary --

  * Makefile.defs: On NetBSD, link with -lm
  * Makefile.defs: Only add -ldl on systems that use it

-- File Changes --

    M src/Makefile.defs (13)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2256.patch
https://github.com/kamailio/kamailio/pull/2256.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2256
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Reply via email to