On 10/29/20 7:41 AM, Amos Jeffries wrote: > The latest Squid have AnyP::Uri::Encode() whic uses a caller provided > buffer.
Just to avoid misunderstanding: AnyP::Uri::Encode() uses a caller-provided buffer as _input_. So does rfc1738*_escape(), of course. That kind of input is unavoidable and is not really the issue that prompted my earlier comments about rfc1738_do_escape() dangers. The primary in-scope problem with rfc1738*_escape() is the _output_ interface. If those functions cannot be completely removed, they should return an SBuf. The exact best input interface will depend on the callers, but it will always remain a "caller provided buffer". HTH, Alex. _______________________________________________ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev
