It was quite fast really as my PR doesn’t address the fundamental design issues nor much of the coding style. A quick win could be to move from a list to an unordered_map, it’s a quite trivial cache in the end. There’s a lot of machinery in there for such a simple data structure :/
On Sat, 4 Apr 2020 at 08:15, Amos Jeffries <squ...@treenet.co.nz> wrote: > On 4/04/20 7:49 pm, Francesco Chemolli wrote: > > I am not sure about what you recommend to do here. > > This cache is IMO over complicated and it breaks layering. > > I’m mostly done in a PR replacing the dlink with a std::list but without > > changing the overall design. It does kill a few tens of lines of code > > and is clearer to read tho. > > > > Well, if you have already done the work it migth as well finish up. I > was thinking you had just done the investigation and not started > refactoring yet. > > Amos > -- @mobile
_______________________________________________ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev
