Hi Yao, Thank you for your review and comments, please see my reply inline.
In order not to add attachment in the email to ML, I uploaded the xml, html and diff html files in the github repository. Please down load the diff file to see the diff: https://github.com/muzixing/SRv6-Path-Segment/blob/main/draft-ietf-spring-srv6-path-segment-10.diff%20(1).html Hope it can address your comments. BR, Cheng From: liu.ya...@zte.com.cn <liu.ya...@zte.com.cn> Sent: Friday, September 6, 2024 8:24 AM To: Cheng Li <c...@huawei.com> Cc: spring@ietf.org; draft-ietf-spring-srv6-path-segm...@ietf.org Subject: Re: [spring] Request for MORE reviews of draft-ietf-spring-srv6-path-segment-09 Hi Cheng, Some comments after reading v-09. Section 3 To identify an SRv6 path, this document defines a new segment called SRv6 Path Segment. An SRv6 Path Segment will not be used for routing so it should not be copied to the IPv6 destination address. [Yao]The word "will" is kind of ambiguous, is it a "SHOULD" / "MUST"? [Cheng]if we need to replace the will, then I think MUST is the correct word. SHOULD is more open, and acceptable for me as well. But using the value of PSID in DA may cause forwarding errors, so it should be forbidden. “An SRv6 Path Segment MUST NOT used for routing so it MUST NOT be copied to the IPv6 destination address.” Section 5 A Path Segment is a local segment allocated by an egress node. A Path Segment can be allocated through several ways, such as CLI, BGP [I-D.ietf-idr-sr-policy-path-segment], PCEP [I-D.ietf-pce-sr-path-segment] or other ways. [Yao] Besides allocating the path segment by the egress, from my reading of draft-ietf-pce-sr-path-segment section 5.2.2.1 , path segment can also be allocate by the controller. And as described in section 3.1, besides as the local segment, the path segment can be a Global ID. So "A Path Segment is a local segment allocated by an egress node." is not accurate. [Cheng]You are correct, since it can be a global ID, then let’s modify the definition. But please aware that the local SID in SRv6 means the SID will be processed locally, and will not be processed on other nodes except looking up the FIB and forwarding. Same here. A PSID is a local SID on the egress node but is unique globally within the domain if it need to be processed on the intermediate nodes. But currently, we do not aim to define the details of this, so it will not be processed on other nodes. Intermediate node processing use case are out of the scope of this document. This document will only focus on the Egress processing only mode. However, we do define the logic to enable and disable the feature of intermediate node processing. Therefore, as long as we make sure that the value of a PSID is unique in processing, that will be fine. Please see the diff to see if you are fine with the modification, since I made some modifications in different parts, so better to discuss based on the diff file. Section 6 When an SRv6 Path Segment is inserted, the SL MUST be initiated to be less than the value of Last Entry, and will not point to SRv6 Path Segment. [Yao] Is the SRv6 Path Segment MUST be inserted by the headend node of an SR policy? It would be helpful to add some rules/recommendations on inserting the path segment. [Cheng]It totally depends on the use case. This draft only define the mechanism of encoding and processing SRv6 Path Segment. A use case will choose to use it or not based on its need. So IMHO, this is out of the scope of the document. Thanks, Yao Original From: ChengLi <c.l=40huawei....@dmarc.ietf.org<mailto:c.l=40huawei....@dmarc.ietf.org>> To: spring@ietf.org<mailto:spring@ietf.org> <spring@ietf.org<mailto:spring@ietf.org>>; Cc: draft-ietf-spring-srv6-path-segm...@ietf.org<mailto:draft-ietf-spring-srv6-path-segm...@ietf.org> <draft-ietf-spring-srv6-path-segm...@ietf.org<mailto:draft-ietf-spring-srv6-path-segm...@ietf.org>>; Date: 2024年09月02日 23:46 Subject: [spring] Request for MORE reviews of draft-ietf-spring-srv6-path-segment-09 Hi SPRING, The SR-MPLS Path Segment draft has been published as RFC9545, and we think the content of SRv6 Path Segment draft is quite stable and mature, so we hope to see more tech reviews on it so that we can move the draft forward. The draft is quite simple and straightforward, and it defines a new type of segment called Path Segment, which is useful to identify an SRv6 path, similar to SR-MPLS path segment. The draft only defines the location that the SRv6 Path Segment should appear, the possible general formats of it, and the general handling of Path Segment. How to allocate the value to a Path Segment is out of the scope of this draft and should be defined as per use cases. An SRv6 Path Segment will not be used for routing so it should not be copied to the IPv6 destination address. Many thanks for Adrian, Stefano and Zafar for their useful comments and help on this draft. More reviews and comments are welcome! Thanks, Cheng -----Original Message----- From: internet-dra...@ietf.org<mailto:internet-dra...@ietf.org> <internet-dra...@ietf.org<mailto:internet-dra...@ietf.org>> Sent: Monday, September 2, 2024 5:15 PM To: i-d-annou...@ietf.org<mailto:i-d-annou...@ietf.org> Cc: spring@ietf.org<mailto:spring@ietf.org> Subject: [spring] I-D Action: draft-ietf-spring-srv6-path-segment-09.txt Internet-Draft draft-ietf-spring-srv6-path-segment-09.txt is now available. It is a work item of the Source Packet Routing in Networking (SPRING) WG of the IETF. Title: Path Segment for SRv6 (Segment Routing in IPv6) Authors: Cheng Li Weiqiang Cheng Mach(Guoyi) Chen Dhruv Dhody Yongqing Zhu Name: draft-ietf-spring-srv6-path-segment-09.txt Pages: 13 Dates: 2024-09-02 Abstract: Segment Routing (SR) allows for a flexible definition of end-to-end paths by encoding an ordered list of instructions, called "segments". The SR architecture can be implemented over an MPLS data plane as well as an IPv6 data plane. Currently, Path Segment has been defined to identify an SR path in SR-MPLS networks, and is used for various use-cases such as end-to- end SR Path Protection and Performance Measurement (PM) of an SR path. This document defines the Path Segment to identify an SRv6 path in an IPv6 network. The IETF datatracker status page for this Internet-Draft is: https://datatracker.ietf.org/doc/draft-ietf-spring-srv6-path-segment/ There is also an HTMLized version available at: https://datatracker.ietf.org/doc/html/draft-ietf-spring-srv6-path-segment-09 A diff from the previous version is available at: https://author-tools.ietf.org/iddiff?url2=draft-ietf-spring-srv6-path-segment-09 Internet-Drafts are also available by rsync at: rsync.ietf.org::internet-drafts _______________________________________________ spring mailing list -- spring@ietf.org<mailto:spring@ietf.org> To unsubscribe send an email to spring-le...@ietf.org<mailto:spring-le...@ietf.org> _______________________________________________ spring mailing list -- spring@ietf.org<mailto:spring@ietf.org> To unsubscribe send an email to spring-le...@ietf.org<mailto:spring-le...@ietf.org>
_______________________________________________ spring mailing list -- spring@ietf.org To unsubscribe send an email to spring-le...@ietf.org
