On Mon, 11 Aug 2008, James.Anderson at Sun.COM wrote: > Hi Valerie - > > I have a question about the sponsor role in code reviews. > Specifically, I am the sponsor of 6613349 for Jason King. > > Is the external contributor responsible for driving the code > review on the appropriate OpenSolaris community email alias?
Yes, please see: http://opensolaris.org/os/communities/participation/ but, it is your job as the sponsor to help them identify the correct code reviewers or aliases to use. > If so, does the sponsor use these reviewers for the RTI? If so, > I assume these reviewers must be Sun engineers. No, they do not have to be Sun engineers, but you want people with expertise with that code... so you'll likely want to have at least one Sun reviewer, but not necessarily. WebRTI can take non Sun email addresses as reviewers & in the CC list (in fact, if you read the sponsor tasks, you'll see you need to list Jason King in the CC list) > Does the sponsor need to also conduct an internal review in > addition to the external contributor driven review? If so, with > the same or different reviewers? Or does the external review suffice? The external review should suffice, since this is an external contribution, the "closed" workspace should not be impacted. > I have seen different descriptions of the code review responsibilities. > > http://opensolaris.org/os/community/on/crt/sponsor-tasks/ > - This document stated that the sponsor will "Help determine ideal design > reviewers (if needed). " > It doesn't explicitly mention code reviewers. next section of the same document says: Help determine ideal code reviewers. > http://www.genunix.org/wiki/index.php/Developer_HOWTO >> 8. Request code review from the proper community or subject experts and cc >> your sponsor. If you're unsure what community to ask for review, ask your >> sponsor for assistance. > > The external contributor has sent email to opensolaris-code > with technical questions regarding the change. Is there a process > to handle a non-response to his emails? Not that I'm aware of. Perhaps opensolaris-code is not the correct alias for this change. As this is setuid related, you may also want to seek assistance on security-discuss at opensolaris.org hope that helps, Valerie -- Valerie Fenwick, http://blogs.sun.com/bubbva Solaris Security Technologies, Developer, Sun Microsystems, Inc. 17 Network Circle, Menlo Park, CA, 94025.
