Acked the series
Frediano
> On Mon, Jul 13, 2020 at 12:12 PM Frediano Ziglio < fzig...@redhat.com >
> wrote:
> > >
>
> > > Hi,
>
> > >
>
> > > > @@ -4795,7 +4796,8 @@ NTSTATUS QxlDevice::HWClose(void)
>
> > > > {
>
> > > > PAGED_CODE();
>
> > > > QxlClose();
>
> > > > - if (m_bUefiMode)
>
> > > > + /* QXL device rev 5+ requires explicit reset to switch to VGA mode */
>
> > > > + if (m_bUefiMode || m_pQxlDod->Revision() > 4)
>
> > > > {
>
> > > > DbgPrint(TRACE_LEVEL_INFORMATION, ("%s: Resetting the device\n",
>
> > > > __FUNCTION__));
>
> > > > WRITE_PORT_UCHAR((PUCHAR)(m_IoBase + QXL_IO_RESET), 0);
>
> > >
>
> > > I'm wondering why this is conditional in the first place?
>
> > > Isn't it a good idea to reset the device on close no matter what?
>
> The intention was to leave the entire procedure as is where possible.
> For example, when we do not use the reset, user screen resize does not happen
> until the BDD starts programming the VGA.
> > >
>
> > > take care,
>
> > > Gerd
>
> > >
>
> > Surely it's less willing to cause possible regressions.
>
> > Frediano
>
_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
