Frediano Ziglio writes: >> Frediano Ziglio writes: >> >> > Do not use G_GUINT32_FORMAT. >> > We support a minimum of 32 bit architectures. >> >> What was wrong with the old code? >> > > Shorter and easier to read. I mean '%u' and '%" G_GUINT32_FORMAT "', > if you have an issue is harder to get it. > For instance it was hard to spot the misleading '0x%" G_GUINT32_FORMAT "' > which got '0x%u' so 100 would be formatted as 0x100 which I would read > as 256, not 100.
Ah, I can understand how this could have been hard to find. Still, even if I now understand where you come from, and even if I know that your patch does not really hurt in practice given what is currently known of the support platforms, I still see that patch as going somewhat in the wrong direction as far as portability best practices are concerned. Reviewed-but-not-entirely-approved-by: Christophe de Dinechin <dinec...@redhat.com> > >> If you want to get rid of G_ macro dependencies, why not use PRIu32? >> > > No, G_ macros are fine, also taking into account that PRIu64 and > G_GUINT64_FORMAT > could be different (for instance in Windows) and that the receiving formatting > function accepts better the G_ version (they are GLib). This comment, while it reinforces your rationale, made me extremely sad ;-) -- Cheers, Christophe de Dinechin (IRC c3d) _______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
