On 5/1/19 2:30 PM, Frediano Ziglio wrote:
One test is enough -- do it in makecheck.
Must git clean first any previous builds.
No, not at the beginning.
spice-gtk CI script execute multiple test in a single job
so between jobs clean everything.
Well, it fails without it, with the following error messages:
configure: error: source directory already configured; run "make
distclean" there first
configure: error: ../../../subprojects/spice-common/configure failed
for subprojects/spice-common
https://gitlab.freedesktop.org/uril/spice/-/jobs/271029
Signed-off-by: Uri Lublin <u...@redhat.com>
---
Since V1:
- Add a comment about out-of-tree
- cleanup previous builds using git clean
pipeline task:
https://gitlab.freedesktop.org/uril/spice/-/jobs/272659
BTW, should we cleanup before/after every task ?
should we rm -rf builddir ? spice-protocol ?
Well, we should clean between, not at the beginning, at
the beginning repository is supposed to came from a git clone.
I see "Fetching changes...", which seems to me like there is no
new clone, but a git fetch.
I'm not sure yet why it works in spice-gtk.
Thanks,
Uri.
---
.gitlab-ci.yml | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 9ce95c00e..2c1f46adf 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -14,12 +14,18 @@ before_script:
makecheck:
script:
+ # Also check out-of-tree build
+ - git clean -fdx # cleanup after previous builds
+ - git submodule foreach --recursive git clean -fdx
There 2 lines here are useless.
+ - mkdir builddir
+ - cd builddir
- >
CFLAGS='-O2 -pipe -g -fsanitize=address -fno-omit-frame-pointer
-Wframe-larger-than=40920'
LDFLAGS='-fsanitize=address -lasan'
- ./autogen.sh --enable-celt051
+ ../autogen.sh --enable-celt051
- make
- make -C server check || (cat server/tests/test-suite.log && exit 1)
+ - cd ..
meson-makecheck:
script:
Otherwise,
Acked-by: Frediano Ziglio <fzig...@redhat.com>
Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
