On 2/28/19 11:38 AM, Victor Toso wrote:
Hi,
On Thu, Feb 28, 2019 at 11:04:51AM +0200, Uri Lublin wrote:
On 2/25/19 2:08 PM, Victor Toso wrote:
On Mon, Feb 25, 2019 at 12:20:06PM +0200, Uri Lublin wrote:
When building with older mingw, sprintf_s does not
always work as expected, but snprintf does.
Also it's more consistent in the file.
Note that when building with VS, snprintf becomes sprintf_s
I really don't mind to have this patch (I might have proposed it
long time ago even, not sure) but overall this should have been
fixed by rebase on mingw-crt, no?
I think it should be fixed by a rebase of mingw-crt.
Do you want me to mention it in the commit log ?
Looking at tags that contain the fix:
$ git tag --contains 9975303
v5.0-rc1
v5.0-rc2
v5.0.0
v5.0.1
v5.0.2
v5.0.3
v5.0.4
v6.0.0
So perhaps adding `Fixed in mingw-w64 at v5.0.0 by 9975303 (CRT:
vsprintf_s calling wrong function)` would be fine.
This tag is from Oct 17, 2016 so indeed, quite old!
I'll add it.
Thanks,
Uri.
_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
