Hey, On Wed, Jan 30, 2019 at 01:36:40PM +0100, Jakub Janku wrote: > > diff --git a/src/vdagent/vdagent.c b/src/vdagent/vdagent.c > > index ff3328c..b077d1d 100644 > > --- a/src/vdagent/vdagent.c > > +++ b/src/vdagent/vdagent.c > > @@ -20,6 +20,7 @@ > > */ > > #include <config.h> > > > > +#include <stdbool.h> > > Why this include here? Can't we just use gboolean instead of bool, > like in the rest of the file?
In spice-server, we favour bool over gboolean as it's slightly better from a type-safety perspective (bool is a different type from int to the C compiler, while gboolean is a typedef for an int, thus bool/int mismatches trigger warnings that gboolean would not). However, ack to the consistency argument, I'll switch to gboolean here. Christophe
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
