Ok, g_abort() is only available in 2.50, and only the meson build uses GLIB_VERSION_MAX_ALLOWED. However, since this can be useful, I'd prefer that we keep GLIB_VERSION_MAX_ALLOWED, and add it to the autotools build. This specific issue can be fixed by using g_error() instead of g_abort(). I'll send patches for that.
Christophe
On Fri, Jul 06, 2018 at 11:12:27AM -0300, Eduardo Lima (Etrunko) wrote:
> This was causing errors compiling pixman_utils.c:
>
> ../common/pixman_utils.c: In function 'spice_surface_format_to_pixman':
> ../common/pixman_utils.c:939:9: error: implicit declaration of function
> 'g_abort'; did you mean 'abort'? [-Werror=implicit-function-declaration]
> g_abort();
> ^~~~~~~
> abort
>
> Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com>
> ---
> meson.build | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 2b91e82..3513d37 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -159,8 +159,7 @@ endif
> #
> glib_major_minor = glib_version.split('.')
> glib_encoded_version = 'GLIB_VERSION_@0@_@1@'.format(glib_major_minor[0],
> glib_major_minor[1])
> -spice_common_global_cflags +=
> ['-DGLIB_VERSION_MIN_REQUIRED=@0@'.format(glib_encoded_version),
> -
> '-DGLIB_VERSION_MAX_ALLOWED=@0@'.format(glib_encoded_version)]
> +spice_common_global_cflags +=
> ['-DGLIB_VERSION_MIN_REQUIRED=@0@'.format(glib_encoded_version)]
>
> foreach arg : spice_common_global_cflags
> add_project_arguments(arg, language : 'c')
> --
> 2.14.4
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
