Hey, On Thu, Feb 08, 2018 at 10:13:21AM +0100, Lukáš Hrázký wrote: > On Thu, 2018-02-08 at 04:02 -0500, Frediano Ziglio wrote: > > > > > > From: Christophe de Dinechin <dinec...@redhat.com> > > > > > > The objective of these guidelines is that: > > > - We avoid introducing new warnings > > > - We know how to fix old ones > > > - We don't have to isolate whitespace changes when submitting patches, > > > i.e. someone who use tools that automatically strip whitespaces and > > > therefore "repairs" earlier errors should not be punished for it. > > > > Sorry, I don't agree with the automatic tool, patches should not > > contain extra changes unless they fix space changes while changing > > these lines for other reasons. > > I'll personally accept single patches fixing the spaces. > > I'm with Frediano here. If you want to automatically fix whitespace > errors, you can do it in a separate commit without much effort? > > I can also go right now and fix all trailing whitespaces with a bash > oneliner, submit the patch and we have a moot point here? :)
Well, it was nacked before :) https://lists.freedesktop.org/archives/spice-devel/2016-May/029603.html
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
