On Mon, Oct 31, 2016 at 06:10:59AM -0400, Frediano Ziglio wrote: > > > > On Fri, Oct 28, 2016 at 11:59:54AM +0100, Frediano Ziglio wrote: > > > These fields need just channel to be set to be initialized. > > > Move their initialization to constructor to make sure > > > they are initialized as soon as possible. > > > > Why? > > > > > Read previous reply to "red-channel-client: Init pipe field during init". > To sum up current code could lead to use of not initialized fields due to > order > changes introduced.
This should be in the commit log. > > > Not related to this patch, but I'm not sure initializing pos and size to > > 0 is required, 'priv' will be memset to 0 upon creation. > > > > Christophe > > > > I just moved the code. > I think would be better to remove with another patch if you like to. Yeah, as I said, not related to this patch :) Not even important, just something useful to have in mind for future code/reviews. Christophe
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
