----- Original Message ----- > From: "Frediano Ziglio" <fzig...@redhat.com> > To: "Dmitry Fleytman" <dmi...@daynix.com> > Cc: "Spice List" <spice-devel@lists.freedesktop.org> > Sent: Tuesday, September 6, 2016 1:30:44 PM > Subject: Re: [Spice-devel] [PATCH qxl-wddm-dod v2 12/25] Rename mspace.c to > mspace.cpp
> > > On 6 Sep 2016, at 15:07 PM, Frediano Ziglio < fzig...@redhat.com > wrote: > > > > > > > On Mon, Sep 5, 2016 at 9:26 PM, Frediano Ziglio < fzig...@redhat.com > > > > > wrote: > > > > > > > > > > > Why the rationale was removed? > > > > > > > > > > > > > > By mistake, i'll add it back in the next version. > > > > > > > > > > > By the way this was a workaround for a VS bug, get Visual Studio 2015 > > > > > Update > > > > > 1 (actually we are at update 3) > > > > > > > > > > > > > > True, however microsoft recommends using visual c++ compiler profile as > > > > it > > > > is > > > > different from the c compiler profile. > > > > > > > > > Yes, especially if you don't know what you are doing and you don't have a > > > acceptable test suite. > > > > > > I hope that they all don't apply to us. > > > > > Hi Frediano, > > > Actually using Microsoft C++ compiler for C files is recommended because it > > performs > > > more excessive static checks and produces warnings regarding more potential > > problematic cases. > > > And this is definitely a good thing. > > > ~Dmitry > > Yes... C++ does more strictly checks. This does not means that all C > programmers are moving to a C++ compiler! The mspace.c file is shared between different projects where some require it to be C. Rename to .cpp can cause maintainability issue as it's easier to introduce C++ construct that would lead to a fork. As the initial rationale (a workaround for a VS bug) didn't apply anymore I would avoid the rename. Frediano
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
