Thank you for those reviews. I sent the updated patches now.
On 03/31/16 22:12, Frediano Ziglio-san wrote:
You should handle WM_INPUTLANGCHANGE so use can change layout while using remote-viewer. Another option is not cache the value but just call GetKeyboardLayout(0) every time.
I succeeded to hack WM_INPUTLANGCHANGE with GetCurrentThreadId(). It seems the global hook is not permitted without the thread id. I'm not sure if GetModuleHandle(NULL) is needed.
You probably want to support also VK_DBE_CODEINPUT (Control + Alt + Eisu) VK_DBE_ENTERIMECONFIGMODE (Control + Alt + Zenkaku_Hankaku) VK_KANA (Shift + Control + Hiragana_Katakana) VK_DBE_ENTERWORDREGISTERMODE (Control+Alt+Muhenkan)
I added those cases.
Note that also some combinations (like Control+Alt+Shift+Hiragana) produce no events.
Yeah, it seems GDK does not receive that event.
I'm not sure this patch is portable between Windows 7 and Windows 10.
OK, I will find time to try Windows 10. _______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
