On Fri, Dec 05, 2014 at 07:18:50PM +0100, Marc-André Lureau wrote: > Where did you see that all patches have to be mandatorily reviewed in > Spice? We always had a trivial push rule, and you always complained > about it. That's all I know.
What I remember from my first few years in SPICE was that all patches were going to the mailing lists before push. I don't remember any patch being pushed without prior review. Then it was implicitly agreed that a trivial push rule would not hurt, and I started complaining about some dubious patches you pushed abusing that rule. I don't remember complaining about anyone else's patch, nor seeing a lot of trivial pushes from anyone else (I've done a few myself, most of the time one liners or so). Christophe
pgpZnVPHbePHD.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
