Re: [Spice-devel] [PATCH spice-gtk] proxy: use http proxy by default if no scheme given

[Christophe Fergeau]

On Tue, Jun 17, 2014 at 07:18:37PM +0200, Marc-André Lureau wrote:
> SPICE_PROXY used to accept URI without scheme, falling back on
> http/3128. This is a regression introduced with 5dcab09ac
> ---
>  gtk/spice-uri.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/gtk/spice-uri.c b/gtk/spice-uri.c
> index cf6e71b..82aefdb 100644
> --- a/gtk/spice-uri.c
> +++ b/gtk/spice-uri.c
> @@ -90,7 +90,8 @@ gboolean spice_uri_parse(SpiceURI *self, const gchar *_uri, 
> GError **error)
>          spice_uri_set_scheme(self, "https");
>          spice_uri_set_port(self, 3129);
>      } else {
> -        return FALSE;
> +        spice_uri_set_scheme(self, "http");
> +        spice_uri_set_port(self, 3128);
>      }

ACK, though maybe it would be worth checking the URI does not start with
an unknown scheme (ie foo://spice.example.com:1234)

Christophe

pgpB90sZDIxhy.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel