On Wed, Oct 16, 2013 at 01:13:10PM -0400, Marc-André Lureau wrote: > > > ----- Original Message ----- > > While looking at the SASL code, I noticed some memory leaks in error paths. > > This commit adds a cleanup: block to free some of the memory dynamically > > allocated in that function, and remove the corresponding g_free() from > > the regular code flow. This should ensure that both the regular path > > and the error paths free the same memory. > > --- > > > > Something like this? > > yes! ack (assuming it is tested :)
It's tested in the sense that I've successfully a sasl session with that change, and that I've added random goto error in that function, and did not get bad results (auth failed). I can test some more with valgrind if that makes you more confident about the code ;) Christophe
pgp7I2jDxo84G.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
