On Tue, Oct 08, 2013 at 08:32:26AM -0500, Jeremy White wrote: > >On old client connection, new qemu/new spice-server should also use celt, > >the old client should be able to decode that even if it's 48kHz. > > Perhaps; but the number of hard coded values, and the fact > that this code has never been run at anything but 44.1 makes me nervous.
I've just built spice-server+qemu with
diff --git a/server/spice.h b/server/spice.h
index b645112..ffc4a91 100644
--- a/server/spice.h
+++ b/server/spice.h
@@ -342,7 +342,7 @@ enum {
SPICE_INTERFACE_AUDIO_FMT_S16 = 1,
};
-#define SPICE_INTERFACE_PLAYBACK_FREQ 44100
+#define SPICE_INTERFACE_PLAYBACK_FREQ 48000
#define SPICE_INTERFACE_PLAYBACK_CHAN 2
#define SPICE_INTERFACE_PLAYBACK_FMT SPICE_INTERFACE_AUDIO_FMT_S16
and basic playback is fine, I didn't test more.
> At the very least, won't you have rate drift, so movies, for example,
> will get out of sync?
Fwiw, I had the same concerns with respect to resampling :)
Christophe
pgpN6WM2yVT4C.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
