On 04/09/2012 09:49 AM, Hans de Goede wrote:
Hi,
On 04/08/2012 08:44 PM, Alon Levy wrote:
On Sun, Apr 08, 2012 at 06:42:36PM +0300, Yonit Halperin wrote:
For STREAM_DATA_SIZED and QOS_QUERY messages.
Signed-off-by: Yonit Halperin<yhalp...@redhat.com>
---
common/rect.h | 2 +-
spice-protocol | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/rect.h b/common/rect.h
index 0e4b01e..a9c1b08 100644
--- a/common/rect.h
+++ b/common/rect.h
@@ -131,7 +131,7 @@ static inline int rect_contains(const SpiceRect&
big, const SpiceRect& small)
static inline int rect_get_area(const SpiceRect& r)
{
- return rect_contains(&r);
+ return rect_get_area(&r);
This isn't mentioned in the commit message.
And it looks like it turns this function into a function recursing into
itself, unless
we're relying on c++ function overloading here, but common is supposed
to be C-only.
Likewise the function prototype looks like it is using c++ conventions,
but again common
is supposed to be C only.
This file has
#ifdef __cplusplus where all the c functions are overloaded with
reference data types. The c++ client use this.
Regards,
Hans
_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
