On Sun, Oct 09, 2011 at 07:21:13PM +0200, Marc-André Lureau wrote: > Hi > > On Sun, Oct 9, 2011 at 7:02 PM, Alon Levy <al...@redhat.com> wrote: > >> However, red_log(2, "blah"); is bad for several reasons. Why not use > >> red_debug()? > > The point was to add some log levels, 1 is LOG_WARN. I can make 2 > > LOG_DEBUG, then that 2 goes away, but anyone can add a red_log(3, > > "blah") visible only with SPICE_LOG_LEVEL=3+. > > red_debug("foo") would be easier to change later on. Log levels don't > need to be specified explicitely.
yes, I meant adding LOG_DEBUG and making red_debug be red_log(LOG_DEBUG, same as red_warn is red_log(LOG_WARN). > > -- > Marc-André Lureau > _______________________________________________ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/spice-devel _______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel