Hi,
On Mon, Jun 20, 2011 at 01:18:04PM +0200, Alon Levy wrote:
> ---
> server/red_worker.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index bee86b9..12f7fa5 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -836,6 +836,7 @@ typedef struct RedWorker {
>
> uint32_t shadows_count;
> uint32_t containers_count;
> + uint32_t stream_count;NACK from me on this patch, I'd rather remove all these unused debug variables which are only incremented/decremented and are not used for anything else. We already have (at least) current_size, shadows_count, containers_count, transparent_count and drawable_count which clutter RedWorker for no obvious gain. In this case, ring_get_length(&worker->stream_link) might do the trick. After having spent a few hours looking at red_worker.c, I really think we should work on splitting it in smaller pieces, it's too huge and doing too many things imo (it implements a main loop, message dispatching, it has creation/destruction functions for various small objects, it has some tree iteration code, it implements movie detection, ...). However, this would cause bad conflicts in the pending multiclient work :( Christophe
pgpwQxukL0iCu.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
