Hi, On Mon, Jun 20, 2011 at 11:47 PM, Christophe Fergeau <cferg...@redhat.com> wrote: > Hi, > > On Mon, Jun 20, 2011 at 11:19:43PM +0200, Marc-André Lureau wrote: >> This is to satisfy a changed manually in >> 9d5ef9beeca722b2ceff7d15aaa3aaaaf07ecfbf when one regenerate enums.h. > > The patch looks good to me, though I don't understand what the commit > message means, can you improve it? :)
Sure, what about: Commit 9d5ef9beeca722b2ceff7d15aaa3aaaaf07ecfbf in spice-protocol introduced a typedef manually in the generated enums.h header. This patch adds them automatically to all enums during enums.h generation. >> --- >> python_modules/ptypes.py | 22 +++++++++++++++------- >> 1 files changed, 15 insertions(+), 7 deletions(-) >> >> diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py >> index 9c4b7de..f12a2f3 100644 >> --- a/python_modules/ptypes.py >> +++ b/python_modules/ptypes.py >> @@ -37,10 +37,10 @@ class FixedSize: >> new.vals[i] = self.vals[i] + other.vals[i] >> >> for i in range(shared,len(self.vals)): >> - new.vals[i] = self.vals[i]; >> + new.vals[i] = self.vals[i] >> >> for i in range(shared,len(other.vals)): >> - new.vals[i] = new.vals[i] + other.vals[i]; >> + new.vals[i] = new.vals[i] + other.vals[i] >> > > These 2 changes are unrelated to this commit. It's just removing a C-ism with a trailing; I will split it. -- Marc-André Lureau _______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
