On Tue, May 10, 2011 at 10:38:52AM +0200, Christophe Fergeau wrote: > On Sun, May 08, 2011 at 04:10:57PM +0300, Alon Levy wrote: > > should change all the enums that don't explicitly set their first value to > > 0. > > I'm not really convinced this is useful, what does that bring us? > > There are probably some enums where the actual int values of the enum members > don't matter, so changing these ones would give the false impression that > it's important that the first member is 0 while it's not. For the ones > where the exact int value is important, why not, but I don't know if there > are many of these?
I just dislike ungrounded enums. My only reason for this is that when debugging, i.e. printing via printf/debugger I'm just using the implicit knowledge that the compiler actually uses 0 as the first value. Why not make it explicit? > > Christophe _______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel