Hi,

One very small nitpick, still: Ack!

On 12/06/2010 05:16 PM, Alon Levy wrote:
---
  server/reds.c      |   26 +++
  server/smartcard.c |  532 ++++++++++++++++++++++++++++++++++++++++++++++++++++
  server/smartcard.h |   18 ++
  3 files changed, 576 insertions(+), 0 deletions(-)
  create mode 100644 server/smartcard.c
  create mode 100644 server/smartcard.h

diff --git a/server/reds.c b/server/reds.c
index 517ac6d..9e12073 100644
--- a/server/reds.c
+++ b/server/reds.c

<snip>

@@ -3432,9 +3436,15 @@ __visible__ void 
spice_server_char_device_wakeup(SpiceCharDeviceInstance* sin)
  }

  #define SUBTYPE_VDAGENT "vdagent"
+#ifdef USE_SMARTCARD
+#define SUBTYPE_SMARTCARD "smartcard"
+#endif


I see little value in the #ifdef #endif pair above.

  const char *spice_server_char_device_recognized_subtypes_list[] = {
      SUBTYPE_VDAGENT,
+#ifdef USE_SMARTCARD
+    SUBTYPE_SMARTCARD,
+#endif
      NULL,
  };


<snip>

Regards,

Hans
_______________________________________________
Spice-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/spice-devel

Reply via email to