Hi, Thanks for looking though the patch :)
On Wed, Sep 29, 2010 at 5:46 PM, Alexander Larsson <al...@redhat.com> wrote: > On Sun, 2010-09-26 at 14:57 +0200, Attila Sukosd wrote: > > Hi All, > > > > I finally had a bit of time to gather the changes to the spice client > > in order to get it working under Mac. > > Good stuff. I landed some of the cleanup from this patch as: > > http://lists.freedesktop.org/archives/spice-devel/2010-September/001249.html > > Also, I did a new version of the select patch that further simplifies > things: > > http://lists.freedesktop.org/archives/spice-devel/2010-September/001264.html > Waiting for review on it... > > Further review: > > Why the GPL change? All other headers are LGPL 2.1 anyway, and we want > the client LGPL anyway so it can be librariefied. > Yea, sorry bout the licensing change, I guess the old sources had some different licensing. > > +#if defined(__APPLE__) || defined(__MACH__) > +#ifndef MSG_NOSIGNAL > +#define MSG_NOSIGNAL SO_NOSIGPIPE > +#endif > +#endif > > This is not right. SO_NOSIGPIPE is not used in the same way as > MSG_NOSIGNAL. > See e.g. > http://lists.policyd.org/pipermail/devel/2007-September/000468.html > > Hmm, thats good to know. > In general we want to avoid sprinkling __LINUX__ or __APPLE__ defines in > the "unixy" code (its hard to avoid for win32 though). Instead we want > to check things in configure and use proper HAVE_FOO checks, etc. > > So, for instance we'd have HAVE_ALSA (or maybe USE_ALSA in this case > since we might have multiple detected sound system in any particular > system), rather than __LINUX__ checks. And similar for the thread stuff. > > Yes, I agree, but it was just much easier to play around with it, without having to modify too much in the autoconf stuff. > Anyway, if you rebase your patch based on the stuff thats landed things > should look much easier for you to handle. > >
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
