Module Name: src Committed By: mrg Date: Wed May 8 06:31:02 UTC 2019
Modified Files: src/sys/dev/usb: xhci.c Log Message: new comment explains this hack: * XXXMRG: Stall task can run after slot is disabled when yanked. * This hack notices that the xs has been memset() in * xhci_disable_slot() and returns. Both xhci_reset_endpoint() * and xhci_set_dequeue() rely upon a valid ring setup for correct * operation, and the latter will fault, as would * usb_transfer_complete() if it got that far. this truly fixes yanking active ucom devices (uchcom, uplcom and umcs all tested.) prior efforts largely worked by allowing the stall task to run first, as a side effect to their actual work. ok @skrll. XXX: pullup. To generate a diff of this commit: cvs rdiff -u -r1.106 -r1.107 src/sys/dev/usb/xhci.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.