Module Name: src
Committed By: msaitoh
Date: Mon Nov 3 16:47:29 UTC 2014
Modified Files:
src/sys/arch/sparc/dev [netbsd-6-0]: fd.c
src/sys/arch/sparc64/dev [netbsd-6-0]: fdc.c
src/sys/arch/sun3/dev [netbsd-6-0]: fd.c
Log Message:
Pull up following revision(s) (requested by tsutsui in ticket #1139):
sys/arch/sun3/dev/fd.c: revision 1.78
sys/arch/sparc/dev/fd.c: revision 1.155
sys/arch/sparc64/dev/fdc.c: revision 1.42
Fix panic() on opening fd(4), caused by a wrong pointer passed to memset().
I'm not sure why this 18 year old bug didn't cause problem before
(at least my old 5.99.23 kernel worked), but probably it's triggered
by new gcc 4.8 which might do more aggressive memory allocation.
The problem is found by Nobuyoshi Sato on trying eject(1) against fd(4).
Should be pulled up to netbsd-7.
Sync with sparc/dev/fd.c:1.155.
Fix panic() on opening fd(4), caused by a wrong pointer passed to memset().
I'm not sure why this 18 year old bug didn't cause problem before
(at least my old 5.99.23 kernel worked), but probably it's triggered
by new gcc 4.8 which might do more aggressive memory allocation.
The problem is found by Nobuyoshi Sato on trying eject(1) against fd(4).
Should be pulled up to netbsd-7.
Sync with sparc/dev/fd.c rev 1.155.
Fix panic() on opening fd(4), caused by a wrong pointer passed to memset().
Note sun3 still uses gcc 4.5.4 but also panicked by this old bug,
so probably this problem was triggered by not gcc 4.8 but struct disk
changes (struct disk_geom was added in <sys/disk.h> rev 1.58),
which increased sizeof(struct fd_softc) from 248 bytes to 296 bytes.
(i.e. now struct fd_softc could be allocated in a different pool block,
probably near the wrong pointer of the struct disklabel)
Anyway, this fix should be pullued up to netbsd-7.
(probably I'm the only user of floppy on sun3 though)
To generate a diff of this commit:
cvs rdiff -u -r1.150 -r1.150.14.1 src/sys/arch/sparc/dev/fd.c
cvs rdiff -u -r1.36 -r1.36.14.1 src/sys/arch/sparc64/dev/fdc.c
cvs rdiff -u -r1.72 -r1.72.14.1 src/sys/arch/sun3/dev/fd.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
