Module Name: src
Committed By: yamaguchi
Date: Fri Apr 16 02:12:00 UTC 2021
Modified Files:
src/sys/net: if_pppoe.c if_spppsubr.c
Log Message:
Remove unnecessaly lock holdings to avoid dead lock
The locks were held while callout_halt() and workqueue_wait()
without reason.
And the locks also were held at callout and workqueue handler
so that the handler kicked by those function couldn't acquire
the lock.
The reasons why those are unneccesary are:
- Items of callout_t are protected by callout_lock
- Items of struct workqueue and struct work are protected
by q_mutex in struct workqueue
- Items of struct sppp_work protected by atomic_cas(3)
- struct pppoe_softc does not free before workqueue_wait() and
callout_halt() even if the locks are not held
To generate a diff of this commit:
cvs rdiff -u -r1.167 -r1.168 src/sys/net/if_pppoe.c
cvs rdiff -u -r1.216 -r1.217 src/sys/net/if_spppsubr.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
