Module Name: src
Committed By: rillig
Date: Sun Feb 14 20:22:30 UTC 2021
Modified Files:
src/usr.bin/make: var.c
Log Message:
make: print error about failed shell command before overwriting variable
Memory management of the value of variable expressions is currently more
complicated than necessary. It is the responsibility of ApplyModifiers,
even though conceptually the value belongs to an expression, so it
should rather be in Expr. Right now, this is an alias for
ApplyModifiersState, but that will change soon.
When that is done, there will no longer be a "current value" and a "new
value", only a single "value" of an expression. At that point, before
Expr_SetValueOwn will overwrite the old value with the output of the
shell command, the error message needs to refer to the latter.
To generate a diff of this commit:
cvs rdiff -u -r1.818 -r1.819 src/usr.bin/make/var.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
