Module Name: src
Committed By: rillig
Date: Sat Nov 7 10:16:19 UTC 2020
Modified Files:
src/usr.bin/make: arch.c buf.c compat.c cond.c dir.c for.c job.c main.c
make.c meta.c nonints.h parse.c str.c var.c
Log Message:
make(1): clean up code stylistically
* Replace character literal 0 with '\0'.
* Replace pointer literal 0 with NULL.
* Remove redundant parentheses.
* Parentheses in multi-line conditions are not redundant at the
beginning of a line.
* Replace a few !ptr with ptr == NULL.
* Replace a few ptr with ptr != NULL.
* Replace (expr & mask) == 0 with !(expr & mask).
* Remove redundant braces for blocks in cases where the generated code
stays the same. (Assertions further down in the code would get
different line numbers.)
* Rename parameters in CondParser_String to reflect the data flow.
* Replace #ifdef notdef with #if 0.
The generated code stays exactly the same, at least with GCC 5.5.0 on
NetBSD 8.0 amd64 using the default configuration.
To generate a diff of this commit:
cvs rdiff -u -r1.155 -r1.156 src/usr.bin/make/arch.c
cvs rdiff -u -r1.42 -r1.43 src/usr.bin/make/buf.c
cvs rdiff -u -r1.174 -r1.175 src/usr.bin/make/compat.c
cvs rdiff -u -r1.177 -r1.178 src/usr.bin/make/cond.c
cvs rdiff -u -r1.195 -r1.196 src/usr.bin/make/dir.c
cvs rdiff -u -r1.112 -r1.113 src/usr.bin/make/for.c
cvs rdiff -u -r1.305 -r1.306 src/usr.bin/make/job.c
cvs rdiff -u -r1.432 -r1.433 src/usr.bin/make/main.c
cvs rdiff -u -r1.186 -r1.187 src/usr.bin/make/make.c
cvs rdiff -u -r1.138 -r1.139 src/usr.bin/make/meta.c
cvs rdiff -u -r1.153 -r1.154 src/usr.bin/make/nonints.h
cvs rdiff -u -r1.427 -r1.428 src/usr.bin/make/parse.c
cvs rdiff -u -r1.70 -r1.71 src/usr.bin/make/str.c
cvs rdiff -u -r1.671 -r1.672 src/usr.bin/make/var.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
