Module Name: src Committed By: martin Date: Sat Oct 10 14:36:57 UTC 2020
Modified Files: src/sys/compat/common [netbsd-8]: tty_43.c Log Message: Pull up following revision(s) (requested by nia in ticket #1614): sys/compat/common/tty_43.c: revision 1.38 tty_43: Check a bitset from userspace is valid before shifting it Passing a negative value to these legacy compat ioctls results in left shift on a negative value which is undefined behaviour and results in the tty (at least, possibly other things) locking up. The argument to the ioctl should always be > 0. Return EINVAL otherwise. While here, adjustments to code style to match current guidelines. Found by UBSan. To generate a diff of this commit: cvs rdiff -u -r1.30 -r1.30.20.1 src/sys/compat/common/tty_43.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.