Module Name: src Committed By: rillig Date: Sun Sep 13 08:11:40 UTC 2020
Modified Files: src/usr.bin/make: var.c Log Message: make(1): inline call to strchr in ValidShortVarname It's a pity that neither GCC 5 nor GCC 10 nor Clang 9 inline this code themselves, even though it would be easy to do. Clang 9 at least replaces strchr with memchr, but that is still too complicated for a simple "is this character one of these" question. For a repeated "if (varname != ...)" instead of the switch, GCC 10 generates really boring and inefficient code, even though it is easy to see that the order of the comparisons doesn't matter. To generate a diff of this commit: cvs rdiff -u -r1.507 -r1.508 src/usr.bin/make/var.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.