Module Name: src Committed By: rillig Date: Sat Mar 22 05:46:32 UTC 2025
Modified Files: src/usr.sbin/umcpmioctl: printumcpmio.c putflash.c umcpmioctl.c Log Message: umcpmioctl: apply KNF spacing No binary change. To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/usr.sbin/umcpmioctl/printumcpmio.c \ src/usr.sbin/umcpmioctl/putflash.c cvs rdiff -u -r1.2 -r1.3 src/usr.sbin/umcpmioctl/umcpmioctl.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Modified files: Index: src/usr.sbin/umcpmioctl/printumcpmio.c diff -u src/usr.sbin/umcpmioctl/printumcpmio.c:1.1 src/usr.sbin/umcpmioctl/printumcpmio.c:1.2 --- src/usr.sbin/umcpmioctl/printumcpmio.c:1.1 Mon Dec 16 16:37:40 2024 +++ src/usr.sbin/umcpmioctl/printumcpmio.c Sat Mar 22 05:46:32 2025 @@ -1,4 +1,4 @@ -/* $NetBSD: printumcpmio.c,v 1.1 2024/12/16 16:37:40 brad Exp $ */ +/* $NetBSD: printumcpmio.c,v 1.2 2025/03/22 05:46:32 rillig Exp $ */ /* * Copyright (c) 2024 Brad Spencer <b...@anduin.eldar.org> @@ -17,7 +17,7 @@ */ #ifdef __RCSID -__RCSID("$NetBSD: printumcpmio.c,v 1.1 2024/12/16 16:37:40 brad Exp $"); +__RCSID("$NetBSD: printumcpmio.c,v 1.2 2025/03/22 05:46:32 rillig Exp $"); #endif /* Functions to print stuff */ @@ -104,9 +104,9 @@ print_status(struct mcp2221_status_res * NULL }; - for(int n = 0; n < MCP2221_RES_BUFFER_SIZE;n++) { + for (int n = 0; n < MCP2221_RES_BUFFER_SIZE; n++) { if (outputs[n] != NULL) - printf("%02d:%s%d (0x%02X)\n",n,outputs[n],br[n],br[n]); + printf("%02d:%s%d (0x%02X)\n", n, outputs[n], br[n], br[n]); } } @@ -182,9 +182,9 @@ print_sram(struct mcp2221_get_sram_res * NULL }; - for(int n = 0; n < MCP2221_RES_BUFFER_SIZE;n++) { + for (int n = 0; n < MCP2221_RES_BUFFER_SIZE; n++) { if (outputs[n] != NULL) - printf("%02d:%s%d (0x%02X)\n",n,outputs[n],br[n],br[n]); + printf("%02d:%s%d (0x%02X)\n", n, outputs[n], br[n], br[n]); } } @@ -260,9 +260,9 @@ print_gpio_cfg(struct mcp2221_get_gpio_c NULL }; - for(int n = 0; n < MCP2221_RES_BUFFER_SIZE;n++) { + for (int n = 0; n < MCP2221_RES_BUFFER_SIZE; n++) { if (outputs[n] != NULL) - printf("%02d:%s%d (0x%02X)\n",n,outputs[n],br[n],br[n]); + printf("%02d:%s%d (0x%02X)\n", n, outputs[n], br[n], br[n]); } } @@ -423,24 +423,24 @@ print_flash(struct mcp2221_get_flash_res }; int n = 0; - for(;n <= 2;n++) { + for (; n <= 2; n++) { if (outputs1[n] != NULL) - printf("%02d:%s%d (0x%02X)\n",n,outputs1[n],br[n],br[n]); + printf("%02d:%s%d (0x%02X)\n", n, outputs1[n], br[n], br[n]); } if (subcode == 0 || subcode == 1) { - for(;n < MCP2221_RES_BUFFER_SIZE;n++) { - if (outputs2[subcode][n-3] != NULL) - printf("%02d:%s%d (0x%02X)\n",n,outputs2[subcode][n-3],br[n],br[n]); + for (; n < MCP2221_RES_BUFFER_SIZE; n++) { + if (outputs2[subcode][n - 3] != NULL) + printf("%02d:%s%d (0x%02X)\n", n, outputs2[subcode][n - 3], br[n], br[n]); } } else { int c = 1; int l = br[2]; - printf("%02d:%s%d (0x%02X)\n",n,outputs2[subcode][n-3],br[n],br[n]); + printf("%02d:%s%d (0x%02X)\n", n, outputs2[subcode][n - 3], br[n], br[n]); n++; - for(c = 1;c <= l;c++) { - printf("%02d:%s%02d:\t\t%d (0x%02X)\n",n,outputs2[subcode][1],c,br[n],br[n]); + for (c = 1; c <= l; c++) { + printf("%02d:%s%02d:\t\t%d (0x%02X)\n", n, outputs2[subcode][1], c, br[n], br[n]); n++; } } Index: src/usr.sbin/umcpmioctl/putflash.c diff -u src/usr.sbin/umcpmioctl/putflash.c:1.1 src/usr.sbin/umcpmioctl/putflash.c:1.2 --- src/usr.sbin/umcpmioctl/putflash.c:1.1 Mon Dec 16 16:37:40 2024 +++ src/usr.sbin/umcpmioctl/putflash.c Sat Mar 22 05:46:32 2025 @@ -1,4 +1,4 @@ -/* $NetBSD: putflash.c,v 1.1 2024/12/16 16:37:40 brad Exp $ */ +/* $NetBSD: putflash.c,v 1.2 2025/03/22 05:46:32 rillig Exp $ */ /* * Copyright (c) 2024 Brad Spencer <b...@anduin.eldar.org> @@ -17,7 +17,7 @@ */ #ifdef __RCSID -__RCSID("$NetBSD: putflash.c,v 1.1 2024/12/16 16:37:40 brad Exp $"); +__RCSID("$NetBSD: putflash.c,v 1.2 2025/03/22 05:46:32 rillig Exp $"); #endif /* Functions to parse stuff */ @@ -47,7 +47,7 @@ parse_flash_gp_req(int fd, struct mcp222 error = ioctl(fd, UMCPMIO_GET_FLASH, ¤t_flash); if (debug) - fprintf(stderr,"CURRENT FLASH: error=%d\n",error); + fprintf(stderr, "CURRENT FLASH: error=%d\n", error); if (!error) { int argcount = start; @@ -55,15 +55,17 @@ parse_flash_gp_req(int fd, struct mcp222 uint8_t *bbuf = (uint8_t *)¤t_flash.get_flash_res; if (debug) { - fprintf(stderr,"CURRENT REQ:\n"); - for(int i=0;i < MCP2221_RES_BUFFER_SIZE;i++) { - fprintf(stderr,"%02x ",bbuf[i]); + fprintf(stderr, "CURRENT REQ:\n"); + for (int i = 0; i < MCP2221_RES_BUFFER_SIZE; i++) { + fprintf(stderr, "%02x ", bbuf[i]); } - fprintf(stderr,"\n"); + fprintf(stderr, "\n"); } - /* When flash is put, you put ALL of a particular subcode, so - * you have to do a get + put */ + /* + * When flash is put, you put ALL of a particular subcode, so + * you have to do a get + put + */ req->u.gp.gp0_settings = current_flash.get_flash_res.u.gp.gp0_settings; req->u.gp.gp1_settings = current_flash.get_flash_res.u.gp.gp1_settings; @@ -71,75 +73,75 @@ parse_flash_gp_req(int fd, struct mcp222 req->u.gp.gp3_settings = current_flash.get_flash_res.u.gp.gp3_settings; if (debug) - fprintf(stderr,"CURRENT FLASH: %02x %02x %02x %02x\n", current_flash.get_flash_res.u.gp.gp0_settings, current_flash.get_flash_res.u.gp.gp1_settings, current_flash.get_flash_res.u.gp.gp2_settings, current_flash.get_flash_res.u.gp.gp3_settings); + fprintf(stderr, "CURRENT FLASH: %02x %02x %02x %02x\n", current_flash.get_flash_res.u.gp.gp0_settings, current_flash.get_flash_res.u.gp.gp1_settings, current_flash.get_flash_res.u.gp.gp2_settings, current_flash.get_flash_res.u.gp.gp3_settings); while (argcount < end) { gp = NULL; - if (strncmp(argv[argcount],"GP0",4) == 0) { + if (strncmp(argv[argcount], "GP0", 4) == 0) { gp = (uint8_t *)&req->u.gp.gp0_settings; } - if (strncmp(argv[argcount],"GP1",4) == 0) { + if (strncmp(argv[argcount], "GP1", 4) == 0) { gp = (uint8_t *)&req->u.gp.gp1_settings; } - if (strncmp(argv[argcount],"GP2",4) == 0) { + if (strncmp(argv[argcount], "GP2", 4) == 0) { gp = (uint8_t *)&req->u.gp.gp2_settings; } - if (strncmp(argv[argcount],"GP3",4) == 0) { + if (strncmp(argv[argcount], "GP3", 4) == 0) { gp = (uint8_t *)&req->u.gp.gp3_settings; } if (gp == NULL) { if (debug) - fprintf(stderr,"NOT GPn: %d %s\n",argcount,argv[argcount]); + fprintf(stderr, "NOT GPn: %d %s\n", argcount, argv[argcount]); error = EINVAL; break; } argcount++; if (argcount < end) { arggood = false; - if (strncmp(argv[argcount],"GPIO_PIN_INPUT",15) == 0) { + if (strncmp(argv[argcount], "GPIO_PIN_INPUT", 15) == 0) { *gp &= MCP2221_FLASH_GPIO_VALUE_MASK; *gp |= MCP2221_FLASH_GPIO_INPUT; arggood = true; } - if (strncmp(argv[argcount],"GPIO_PIN_OUTPUT",16) == 0) { + if (strncmp(argv[argcount], "GPIO_PIN_OUTPUT", 16) == 0) { *gp &= MCP2221_FLASH_GPIO_VALUE_MASK; arggood = true; } - if (strncmp(argv[argcount],"GPIO_PIN_ALT0",14) == 0) { + if (strncmp(argv[argcount], "GPIO_PIN_ALT0", 14) == 0) { *gp &= (MCP2221_FLASH_GPIO_VALUE_MASK | MCP2221_FLASH_GPIO_INPUT); *gp &= ~MCP2221_FLASH_PIN_TYPE_MASK; *gp |= MCP2221_FLASH_PIN_IS_ALT0; arggood = true; } - if (strncmp(argv[argcount],"GPIO_PIN_ALT1",14) == 0) { + if (strncmp(argv[argcount], "GPIO_PIN_ALT1", 14) == 0) { *gp &= (MCP2221_FLASH_GPIO_VALUE_MASK | MCP2221_FLASH_GPIO_INPUT); *gp &= ~MCP2221_FLASH_PIN_TYPE_MASK; *gp |= MCP2221_FLASH_PIN_IS_ALT1; arggood = true; } - if (strncmp(argv[argcount],"GPIO_PIN_ALT2",14) == 0) { + if (strncmp(argv[argcount], "GPIO_PIN_ALT2", 14) == 0) { *gp &= (MCP2221_FLASH_GPIO_VALUE_MASK | MCP2221_FLASH_GPIO_INPUT); *gp &= ~MCP2221_FLASH_PIN_TYPE_MASK; *gp |= MCP2221_FLASH_PIN_IS_ALT2; arggood = true; } - if (strncmp(argv[argcount],"GPIO_PIN_ALT3",14) == 0) { + if (strncmp(argv[argcount], "GPIO_PIN_ALT3", 14) == 0) { *gp &= (MCP2221_FLASH_GPIO_VALUE_MASK | MCP2221_FLASH_GPIO_INPUT); *gp &= ~MCP2221_FLASH_PIN_TYPE_MASK; *gp |= MCP2221_FLASH_PIN_IS_DED; arggood = true; } - if (strncmp(argv[argcount],"DEFAULT_OUTPUT_ZERO",20) == 0) { + if (strncmp(argv[argcount], "DEFAULT_OUTPUT_ZERO", 20) == 0) { *gp &= ~MCP2221_FLASH_GPIO_VALUE_MASK; arggood = true; } - if (strncmp(argv[argcount],"DEFAULT_OUTPUT_ONE",19) == 0) { + if (strncmp(argv[argcount], "DEFAULT_OUTPUT_ONE", 19) == 0) { *gp |= MCP2221_FLASH_GPIO_VALUE_MASK; arggood = true; } if (!arggood) { if (debug) - fprintf(stderr,"BAD ARGUMENT: %d %s\n",argcount,argv[argcount]); + fprintf(stderr, "BAD ARGUMENT: %d %s\n", argcount, argv[argcount]); error = EINVAL; break; } @@ -151,5 +153,5 @@ parse_flash_gp_req(int fd, struct mcp222 } } - return(error); + return (error); } Index: src/usr.sbin/umcpmioctl/umcpmioctl.c diff -u src/usr.sbin/umcpmioctl/umcpmioctl.c:1.2 src/usr.sbin/umcpmioctl/umcpmioctl.c:1.3 --- src/usr.sbin/umcpmioctl/umcpmioctl.c:1.2 Sat Mar 22 05:36:27 2025 +++ src/usr.sbin/umcpmioctl/umcpmioctl.c Sat Mar 22 05:46:32 2025 @@ -1,4 +1,4 @@ -/* $NetBSD: umcpmioctl.c,v 1.2 2025/03/22 05:36:27 rillig Exp $ */ +/* $NetBSD: umcpmioctl.c,v 1.3 2025/03/22 05:46:32 rillig Exp $ */ /* * Copyright (c) 2024 Brad Spencer <b...@anduin.eldar.org> @@ -18,7 +18,7 @@ #include <sys/cdefs.h> #ifdef __RCSID -__RCSID("$NetBSD: umcpmioctl.c,v 1.2 2025/03/22 05:36:27 rillig Exp $"); +__RCSID("$NetBSD: umcpmioctl.c,v 1.3 2025/03/22 05:46:32 rillig Exp $"); #endif /* Main userland program that can pull the SRAM and FLASH content from a MCP2221 @@ -52,35 +52,35 @@ usage(void) fprintf(stderr, "Usage: %s [-dh] device cmd args\n\n", p); - for(long unsigned int i = 0;i < __arraycount(umcpmioctlcmds);i++) { + for (long unsigned int i = 0; i < __arraycount(umcpmioctlcmds); i++) { switch (umcpmioctlcmds[i].id) { case UMCPMIO_GET: - for(long unsigned int j = 0;j < __arraycount(getsubcmds);j++) { - fprintf(stderr,"%s [-dh] device %s %s %s\n", - p,umcpmioctlcmds[i].cmd, getsubcmds[j].cmd, getsubcmds[j].helpargs); + for (long unsigned int j = 0; j < __arraycount(getsubcmds); j++) { + fprintf(stderr, "%s [-dh] device %s %s %s\n", + p, umcpmioctlcmds[i].cmd, getsubcmds[j].cmd, getsubcmds[j].helpargs); } break; case UMCPMIO_PUT: - for(long unsigned int j = 0;j < __arraycount(putsubcmds);j++) { - fprintf(stderr,"%s [-dh] device %s %s %s\n", - p,umcpmioctlcmds[i].cmd, putsubcmds[j].cmd, putsubcmds[j].helpargs); + for (long unsigned int j = 0; j < __arraycount(putsubcmds); j++) { + fprintf(stderr, "%s [-dh] device %s %s %s\n", + p, umcpmioctlcmds[i].cmd, putsubcmds[j].cmd, putsubcmds[j].helpargs); } break; default: - fprintf(stderr,"%s [-dh] device %s %s\n", - p,umcpmioctlcmds[i].cmd,umcpmioctlcmds[i].helpargs); + fprintf(stderr, "%s [-dh] device %s %s\n", + p, umcpmioctlcmds[i].cmd, umcpmioctlcmds[i].helpargs); break; }; } - fprintf(stderr,"\n"); - fprintf(stderr,"sram - The SRAM on the chip\n"); - fprintf(stderr,"gp - The GPIO pin state and function\n"); - fprintf(stderr,"cs - Chip Settings\n"); - fprintf(stderr,"usbman - USB Manufacturer Descriptor\n"); - fprintf(stderr,"usbprod - USB Product Descriptor\n"); - fprintf(stderr,"usbsn - USB Serial Number\n"); - fprintf(stderr,"chipsn - Chip Serial Number\n"); + fprintf(stderr, "\n"); + fprintf(stderr, "sram - The SRAM on the chip\n"); + fprintf(stderr, "gp - The GPIO pin state and function\n"); + fprintf(stderr, "cs - Chip Settings\n"); + fprintf(stderr, "usbman - USB Manufacturer Descriptor\n"); + fprintf(stderr, "usbprod - USB Product Descriptor\n"); + fprintf(stderr, "usbsn - USB Serial Number\n"); + fprintf(stderr, "chipsn - Chip Serial Number\n"); } static int @@ -88,8 +88,8 @@ valid_cmd(const struct umcpmioctlcmd c[] { int r = -1; - for(long unsigned int i = 0;i < csize;i++) { - if (strncmp(cmdtocheck,c[i].cmd,16) == 0) { + for (long unsigned int i = 0; i < csize; i++) { + if (strncmp(cmdtocheck, c[i].cmd, 16) == 0) { r = (int)i; break; } @@ -105,7 +105,7 @@ main(int argc, char *argv[]) bool debug = false; int fd = -1, error = 0, valid, validsub = -1, validsubsub = -1; - while ((c = getopt(argc, argv, "dh")) != -1 ) { + while ((c = getopt(argc, argv, "dh")) != -1) { switch (c) { case 'd': debug = true; @@ -121,9 +121,9 @@ main(int argc, char *argv[]) argv += optind; if (debug) { - fprintf(stderr,"ARGC: %d\n", argc); - fprintf(stderr,"ARGV[0]: %s ; ARGV[1]: %s ; ARGV[2]: %s ; ARGV[3]: %s; ARGV[4]: %s; ARGV[5]: %s\n", - argv[0],argv[1],argv[2],argv[3],argv[4],argv[5]); + fprintf(stderr, "ARGC: %d\n", argc); + fprintf(stderr, "ARGV[0]: %s ; ARGV[1]: %s ; ARGV[2]: %s ; ARGV[3]: %s; ARGV[4]: %s; ARGV[5]: %s\n", + argv[0], argv[1], argv[2], argv[3], argv[4], argv[5]); } if (argc <= 1) { @@ -138,7 +138,7 @@ main(int argc, char *argv[]) /* Parse out the command line into what the requested action is */ - valid = valid_cmd(umcpmioctlcmds,__arraycount(umcpmioctlcmds),argv[1]); + valid = valid_cmd(umcpmioctlcmds, __arraycount(umcpmioctlcmds), argv[1]); if (valid != -1) { uint8_t *buf; @@ -151,7 +151,7 @@ main(int argc, char *argv[]) switch (umcpmioctlcmds[valid].id) { case UMCPMIO_GET: if (argc >= 3) { - validsub = valid_cmd(getsubcmds,__arraycount(getsubcmds),argv[2]); + validsub = valid_cmd(getsubcmds, __arraycount(getsubcmds), argv[2]); if (validsub != -1) { switch (getsubcmds[validsub].id) { case UMCPMIO_IOCTL_GET_SRAM: @@ -162,7 +162,7 @@ main(int argc, char *argv[]) break; case UMCPMIO_IOCTL_GET_FLASH: if (argc == 4) { - validsubsub = valid_cmd(getflashsubcmds,__arraycount(getflashsubcmds),argv[3]); + validsubsub = valid_cmd(getflashsubcmds, __arraycount(getflashsubcmds), argv[3]); if (validsubsub != -1) { switch (getflashsubcmds[validsubsub].id) { case UMCPMIO_IOCTL_GET_FLASH_CS: @@ -184,110 +184,110 @@ main(int argc, char *argv[]) ioctl_get_flash.subcode = MCP2221_FLASH_SUBCODE_CHIPSN; break; default: - fprintf(stderr,"Unhandled subcommand to get flash: %s %d\n\n", argv[3], validsubsub); + fprintf(stderr, "Unhandled subcommand to get flash: %s %d\n\n", argv[3], validsubsub); usage(); exit(1); } error = ioctl(fd, UMCPMIO_GET_FLASH, &ioctl_get_flash); } else { - fprintf(stderr,"Unknown subcommand to get flash: %s %d\n\n", argv[3], validsubsub); + fprintf(stderr, "Unknown subcommand to get flash: %s %d\n\n", argv[3], validsubsub); usage(); exit(1); } } else { - fprintf(stderr,"Missing arguments to get flash command\n\n"); + fprintf(stderr, "Missing arguments to get flash command\n\n"); usage(); exit(1); } break; default: - fprintf(stderr,"Unhandled subcommand to get: %s %d\n\n", argv[2], validsub); + fprintf(stderr, "Unhandled subcommand to get: %s %d\n\n", argv[2], validsub); usage(); exit(1); } } else { - fprintf(stderr,"Unknown subcommand to get: %s\n\n", argv[2]); + fprintf(stderr, "Unknown subcommand to get: %s\n\n", argv[2]); usage(); exit(1); } } else { - fprintf(stderr,"Missing arguments to get command\n\n"); + fprintf(stderr, "Missing arguments to get command\n\n"); usage(); exit(1); } break; case UMCPMIO_PUT: if (argc > 3) { - validsub = valid_cmd(putsubcmds,__arraycount(putsubcmds),argv[2]); + validsub = valid_cmd(putsubcmds, __arraycount(putsubcmds), argv[2]); if (validsub != -1) { switch (putsubcmds[validsub].id) { case UMCPMIO_IOCTL_PUT_FLASH: if (argc >= 4) { - validsubsub = valid_cmd(putflashsubcmds,__arraycount(putflashsubcmds),argv[3]); + validsubsub = valid_cmd(putflashsubcmds, __arraycount(putflashsubcmds), argv[3]); if (validsubsub != -1) { switch (putflashsubcmds[validsubsub].id) { case UMCPMIO_IOCTL_PUT_FLASH_GP: - memset(&ioctl_put_flash,0,sizeof(ioctl_put_flash)); + memset(&ioctl_put_flash, 0, sizeof(ioctl_put_flash)); ioctl_put_flash.subcode = MCP2221_FLASH_SUBCODE_GP; error = parse_flash_gp_req(fd, &ioctl_put_flash.put_flash_req, argv, 4, argc, debug); if (debug) { - fprintf(stderr,"REQ FOR FLASH GP PUT: error=%d:\n",error); + fprintf(stderr, "REQ FOR FLASH GP PUT: error=%d:\n", error); buf = (uint8_t *)&ioctl_put_flash.put_flash_req.cmd; - for(int i=0; i < MCP2221_REQ_BUFFER_SIZE; i++) { - fprintf(stderr," %02x",buf[i]); + for (int i = 0; i < MCP2221_REQ_BUFFER_SIZE; i++) { + fprintf(stderr, " %02x", buf[i]); } - fprintf(stderr,"\n----\n"); + fprintf(stderr, "\n----\n"); } - if (! error) + if (!error) error = ioctl(fd, UMCPMIO_PUT_FLASH, &ioctl_put_flash); break; default: - fprintf(stderr,"Unhandled subcommand to get flash: %s %d\n\n", argv[3], validsubsub); + fprintf(stderr, "Unhandled subcommand to get flash: %s %d\n\n", argv[3], validsubsub); usage(); exit(1); }; } else { - fprintf(stderr,"Unknown subcommand to put flash: %s %d\n\n", argv[3], validsubsub); + fprintf(stderr, "Unknown subcommand to put flash: %s %d\n\n", argv[3], validsubsub); usage(); exit(1); } } else { - fprintf(stderr,"Missing arguments to put flash command\n\n"); + fprintf(stderr, "Missing arguments to put flash command\n\n"); usage(); exit(1); } break; default: - fprintf(stderr,"Unhandled subcommand to put: %s %d\n\n", argv[2], validsub); + fprintf(stderr, "Unhandled subcommand to put: %s %d\n\n", argv[2], validsub); usage(); exit(1); }; } else { - fprintf(stderr,"Unknown subcommand to put: %s\n\n", argv[2]); + fprintf(stderr, "Unknown subcommand to put: %s\n\n", argv[2]); usage(); exit(1); } } else { - fprintf(stderr,"Missing arguments to put command\n\n"); + fprintf(stderr, "Missing arguments to put command\n\n"); usage(); exit(1); } break; case UMCPMIO_STATUS: if (debug) - fprintf(stderr,"Doing status\n"); + fprintf(stderr, "Doing status\n"); error = ioctl(fd, UMCPMIO_GET_STATUS, &status_res); if (debug) - fprintf(stderr,"UMCPMIO_GET_STATUS: error=%d, \n",error); + fprintf(stderr, "UMCPMIO_GET_STATUS: error=%d, \n", error); break; default: - fprintf(stderr,"Unknown handling of command: %d\n",valid); + fprintf(stderr, "Unknown handling of command: %d\n", valid); exit(2); } - if (! error) { + if (!error) { switch (umcpmioctlcmds[valid].id) { case UMCPMIO_GET: if (debug) { @@ -302,12 +302,12 @@ main(int argc, char *argv[]) buf = (uint8_t *)&ioctl_get_flash.get_flash_res.cmd; break; default: - fprintf(stderr,"Unhandled subcommand in print for get (debug): %s %d\n\n", argv[2], validsub); + fprintf(stderr, "Unhandled subcommand in print for get (debug): %s %d\n\n", argv[2], validsub); usage(); exit(1); } - for(int i=0; i < MCP2221_RES_BUFFER_SIZE; i++) { - printf(" %02x",buf[i]); + for (int i = 0; i < MCP2221_RES_BUFFER_SIZE; i++) { + printf(" %02x", buf[i]); } printf("\n"); } @@ -320,10 +320,10 @@ main(int argc, char *argv[]) print_gpio_cfg(&get_gpio_cfg_res); break; case UMCPMIO_IOCTL_GET_FLASH: - print_flash(&ioctl_get_flash.get_flash_res,getflashsubcmds[validsubsub].id); + print_flash(&ioctl_get_flash.get_flash_res, getflashsubcmds[validsubsub].id); break; default: - fprintf(stderr,"Unhandled subcommand in print for get: %s %d\n\n", argv[2], validsub); + fprintf(stderr, "Unhandled subcommand in print for get: %s %d\n\n", argv[2], validsub); usage(); exit(1); } @@ -336,12 +336,12 @@ main(int argc, char *argv[]) buf = (uint8_t *)&ioctl_put_flash.put_flash_res.cmd; break; default: - fprintf(stderr,"Unhandled subcommand in print for put (debug): %s %d\n\n", argv[2], validsub); + fprintf(stderr, "Unhandled subcommand in print for put (debug): %s %d\n\n", argv[2], validsub); usage(); exit(1); } - for(int i=0; i < MCP2221_RES_BUFFER_SIZE; i++) { - printf(" %02x",buf[i]); + for (int i = 0; i < MCP2221_RES_BUFFER_SIZE; i++) { + printf(" %02x", buf[i]); } printf("\n"); } @@ -360,7 +360,7 @@ main(int argc, char *argv[]) break; } } else { - fprintf(stderr,"Unhandled subcommand in print for put: %s %d %s %d\n\n", argv[2], validsub, argv[3], validsubsub); + fprintf(stderr, "Unhandled subcommand in print for put: %s %d %s %d\n\n", argv[2], validsub, argv[3], validsubsub); usage(); exit(1); } @@ -368,27 +368,27 @@ main(int argc, char *argv[]) case UMCPMIO_STATUS: if (debug) { buf = &status_res.cmd; - for(int i=0; i < MCP2221_RES_BUFFER_SIZE; i++) { - fprintf(stderr," %02x",buf[i]); + for (int i = 0; i < MCP2221_RES_BUFFER_SIZE; i++) { + fprintf(stderr, " %02x", buf[i]); } - fprintf(stderr,"\n"); + fprintf(stderr, "\n"); } print_status(&status_res); break; default: - fprintf(stderr,"Unknown printing of command: %d\n",valid); + fprintf(stderr, "Unknown printing of command: %d\n", valid); exit(2); } } else { - fprintf(stderr,"Error: %d\n", error); + fprintf(stderr, "Error: %d\n", error); exit(1); } } else { - fprintf(stderr,"Unknown command: %s\n\n",argv[1]); + fprintf(stderr, "Unknown command: %s\n\n", argv[1]); usage(); exit(1); } close(fd); - exit (0); + exit(0); }